Repository navigation
fix(kms): deny on an empty device allowlist in auth-simple - #1344
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/auth-simple-empty-device-allowlist
branch
from
September 24, 2026 03:52
d94a0d6 to
bf655ec
Compare
kvinwang
added a commit
that referenced
this pull request
Sep 25, 2026
#1344 made an empty devices list deny instead of allow. tc-kms-auth-001 now empties both the app and KMS lists on the live listener and expects the device denial, then expects allowAnyDevice to allow the same boot. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1247.
With
allowAnyDevice: falseanddevices: [], auth-simple skipped the device check and allowed every device.DstackApp.isAppAllowedandauth-mockboth deny in that case. auth-simple now denies too, on both the app and KMS paths.Behaviour change: both fields default to those values, so a config that sets neither now denies every device instead of allowing all. To keep the old behaviour, set
allowAnyDevice: trueor list the device ids. Every documented config already setsallowAnyDevice: true.