Repository navigation
test(kms): pin the deliberate TCB policy divergence between auth-simple and the contracts - #1345
Merged
Merged
Conversation
…le and DstackApp A legacy (5-arg) DstackApp leaves requireTcbUpToDate false and so authorizes an out-of-date TCB with advisory IDs, while auth-simple rejects both by default. Both behaviors are intended (spec §3.4/§3.8 backward compatibility vs. fail-closed config-file policy) but the decision itself was unpinned. Assert it on both sides so neither default can flip silently.
kvinwang
force-pushed
the
test/kms-tcb-policy-divergence
branch
from
September 24, 2026 04:13
596ba82 to
1393f46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1247. Tests only — they pass on unmodified code.
auth-simpleandDstackAppintentionally disagree on TCB policy:auth-simpleDstackApp(legacy 5-arg init)DstackApp(requireTcbUpToDate = true)tcbStatus: OutOfDateadvisoryIds: [INTEL-SA-00614]The legacy default is the backward-compatibility behavior from
specification.md§3.4/§3.8.auth-simplehas no per-app owner who could opt in, so it stays strict. Existing tests checked the flag, not the resulting decision. This PR adds that assertion on both sides, with each test referencing the other.