Repository navigation
docs(guest-agent): say why v1 Health names containers ungated - #1360
Merged
Merged
Conversation
The dashboard's container table is gated on `public_sysinfo` or `public_logs`; `Health` names unhealthy containers to anyone. That reads as an oversight until you follow the consumer: `describe_unhealthy` in `gateway/src/proxy/health_check.rs` is the only thing outside the agent that reads the field, its output becomes `Observation.reason`, and `record_instance_health` prints it. Routing uses `healthy` alone -- but that log line is the only place a gateway operator learns which container held an instance out of rotation, and the external listener is one `0.0.0.0` socket, so there is no way to answer the gateway and not answer everyone else. Record the reasoning next to the field.
kvinwang
force-pushed
the
docs/guest-agent-health-names
branch
from
September 24, 2026 09:07
ad3fc87 to
c88ab33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HealthResponse.unhealthynames containers regardless ofpublic_sysinfo/public_logs, which looks like a leak next to the gated dashboard. It is deliberate: the gateway is the consumer, and the external listener has no auth, so it cannot answer only the gateway. Adds a two-line proto comment saying so. Comment-only.