Conversation
Contributor
|
@eltmanm Could you please take a look at the errors that Travis is having in regards to the changes that you made? |
Contributor
|
Like @bonnettd said, we need to have the test cases passing before pushing to master. It just seems to be some flake8 stuff so once we fix that we should be able to merge. |
Author
|
I looked at it but have not familiarity with flake8, and the test cases did not get much why-commenting treatment, you'd be better off asking someone who knows flake8 than me... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorry this did not upload correctly when i sent it the first time.