Repository navigation
chore(ci): run PR cleanup in its own workflow so it is never cancelled - #9
Merged
Merged
Conversation
Cleanup shared ci.yml's per-PR concurrency group with cancel-in-progress, so a newer run in the group could cancel it and leave stages behind; and closing a PR cancelled its in-progress run before the test suites tore down their stages. cleanup.yml has its own group, waits for the PR's CI runs to finish, then destroys the preview and demo stages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Preview deployedApp: https://cafe-web-pr-9-3altvykwkdrowm4o.testing-2b2.workers.dev Built from commit 53ada1b. This comment updates automatically with each push. |
Demo of this previewVideo: https://pub-68e74efbba3b4272943c198da363bcab.r2.dev/pr-9/f45c77a7e77ac538d445eb43c3969d00ed24a33c/demo.mp4 Recorded from commit f45c77a: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cleanup lived in
ci.yml, inside the per-PR concurrency group withcancel-in-progress: true:closedrun itself cancelled the PR's in-progress CI run, soTest.make'safterAll(destroy)and the demo teardown never ran.Either way, stages were left behind.
cleanup.yml: its own workflow, never cancelledIt waits for the PR's CI runs to finish (so nothing deploys after the destroy, and the test suites clean up after themselves), then destroys:
ci.ymlno longer handlesclosedSuperseded pushes still cancel in-progress PR runs. They reuse the same
test-pr-<n>/demo-pr-<n>stages, so the next run deploys over anything the cancelled run left and tears it down at the end.🤖 Generated with Claude Code