GnomadMT plugin ENSVAR-6912#820
Merged
ainefairbrother merged 21 commits intoEnsembl:mainfrom Feb 16, 2026
Merged
Conversation
Member
Author
|
Converted back to draft as needing rework to take gnomAD data from the complete vcf (incl haplotype info) instead of the reduced tsv file that is used atm. |
mluypaert
force-pushed
the
gnomad-mt_ENSVAR-6912
branch
from
f65cc01 to
3079a5a
Compare
mluypaert
force-pushed
the
gnomad-mt_ENSVAR-6912
branch
from
42d8bef to
edb4ae7
Compare
ainefairbrother
requested changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Thanks for this plugin @mluypaert - some potential bugs highlighted as well as a couple of suggestions.
Member
Author
|
@ainefairbrother Thanks for the feedback and suggestions. I've implemented all of them, so this should now be ready for approval. |
ainefairbrother
requested changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Thanks for those changes @mluypaert, looks good to me!
Couple of tiny text things, then good to go.
ainefairbrother
approved these changes
Feb 16, 2026
Contributor
ainefairbrother
left a comment
ainefairbrother
left a comment
There was a problem hiding this comment.
LGTM! Thanks @mluypaert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.