fix(web): Copy CRL URL on local http hosts - #138
Merged
Merged
Conversation
navigator.clipboard.writeText is blocked outside a secure context, so Copy CRL URL failed silently on local lvh.me. Fall back to execCommand and toast when copy still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy CRL URL used `navigator.clipboard.writeText`, which is blocked on `http://app.lvh.me:8001\` (not a secure context) and failed with no toast. The copy hook now falls back to `document.execCommand("copy")` and the Certificates button toasts on failure.
Program / phase
No-piggyback checklist
Tests
Clipboard fallback; other copy buttons (API keys, env values) get the same fix.
Risk / rollout
None. Client-only.