[analyzer] Completely remove -analyzer-opt-analyze-headers #4760
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is an undocumented, off-by default flag in upstream Clang. We have measured that disabling this lead to an overall ~24% decrease in analysis time with some loss and shifting around of the result set on open source projects, and concluded that it worth disabling. Users still should have the possiblity of enabling this via configuring the analyzer with analyzer options, but not the other way around: there is no flag to disable this functionality once it is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is an undocumented, off-by default flag in upstream Clang. We have measured that disabling this lead to an overall ~24% decrease in analysis time with some loss and shifting around of the result set on open source projects, and concluded that it worth disabling. Users still should have the possiblity of enabling this via configuring the analyzer with analyzer options, but not the other way around: there is no flag to disable this functionality once it is enabled.