Repository navigation
fix(ce-noslop): keep claim certainty and rule out semicolons as dash substitutes #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The new scheduler serves as a key enabler for the platform team. It can help reduce queue delays during peak hours, and it typically keeps p95 wait time under 2 seconds, which is a testament to the team's tireless work. Moreover, it might allow us to retire the legacy cron host next quarter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The importer reads each CSV file in one pass — no temp files, no second scan. Rows that fail validation go to a quarantine table — the run keeps going. Fast. Predictable. Safe to rerun. On the staging cluster the nightly job finishes in about 6 minutes for 2 million rows — and nobody has to babysit it. |
13 changes: 13 additions & 0 deletions
13
tests/skill-eval-cell/fixtures/noslop-drafts/release-notes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Release 4.2 | ||
|
|
||
| This isn't just a maintenance release — it's a rethink of how sync works. Three changes. One goal: fewer surprises. | ||
|
|
||
| **Incremental sync.** The sync engine now tracks changes per folder — not per account. In our internal benchmarks, a typical workspace syncs up to 40 percent faster, and large monorepos should see bigger gains. Results will vary with network conditions. | ||
|
|
||
| **Conflict handling.** Previously, a conflicting edit was silently overwritten — the last writer won. Now the client keeps both copies and flags the file. No data loss. No guesswork. Just a clear choice. We expect this to remove most of the support tickets we get about lost edits, though some edge cases with renamed folders may still slip through. | ||
|
|
||
| **Offline mode.** The client can now queue up to 500 changes while offline — and replays them in order when the connection returns. Queued changes older than 7 days are discarded. Simple. Reliable. Done. | ||
|
|
||
| The result: sync that just works — quietly, predictably, in the background. We think this is the most significant improvement to the client since 3.0, and it may let us retire the legacy polling service by the end of Q1. | ||
|
|
||
| Upgrading is seamless — install 4.2 over your current version. Settings carry over. Nothing to configure. |
9 changes: 9 additions & 0 deletions
9
tests/skill-eval-cell/fixtures/noslop-drafts/status-update.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Quick update on the checkout latency investigation — here's where things stand. | ||
|
|
||
| It's important to note that we have likely found the main cause. The payment-service pool appears to be exhausted under load — at peak we saw 48 of 50 connections in use, and request queueing seems to account for most of the extra 900 ms at p99. That said, we haven't ruled out the retry storm in the inventory client — it could potentially be contributing as well. | ||
|
|
||
| The fix we're testing raises the pool size to 120 and adds a 2-second acquire timeout. In staging, this significantly reduced p99 latency — from about 1.4 s to roughly 600 ms in a 20-minute load test. It should hold up in production, but we haven't confirmed that yet, and staging traffic is not a perfect match for real traffic. | ||
|
|
||
| Next steps: roll the change to 10 percent of production traffic on Thursday, watch p99 and the database CPU for 24 hours, and then decide whether to go to 100 percent. If database CPU goes above 70 percent, we'll roll back. We may also need to revisit the inventory retries — but that's a separate ticket. | ||
|
|
||
| Bottom line: we're cautiously optimistic — but not done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.