Findchat group name treatment#1420
Merged
DavidsonGomes merged 3 commits intoEvolutionAPI:developfrom May 13, 2025
Merged
Conversation
ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us
Contributor
Reviewer's GuideThis pull request modifies a SQL query within Entity Relationship Diagram: Updated 'pushName' SourceerDiagram
TITLE "ER Diagram: Change in pushName Data Source"
Contact ||--o{ Chat : "related via remoteJid (implied)"
Contact {
string id PK
string remoteJid UK
string pushName "<- Previously used for alias"
string profilePicUrl
}
Chat {
string name "<- Now used for 'pushName' alias"
string remoteJid UK "Implied join key"
}
Message {
bigint messageTimestamp "Used in COALESCE"
}
Contact ||--o{ Message : "related (implied by query)"
note "The query alias 'pushName' now sources data from Chat.name instead of Contact.pushName."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @luiis716 - I've reviewed your changes - here's some feedback:
- Ensure using
Chat.nameis correct for individual chats as well, not just groups identified by@g.us. - Consider if the
pushNamealias should be renamed now that it sources fromChat.name.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
|
Estava na branch main, na mudança para a develop gereu conflitos, corrija por favor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us
Summary by Sourcery
Enhancements: