Update fetchStatusMessage to handle empty offset / page#1536
Merged
DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom Jun 3, 2025
Daquisu:fix-fetchStatusMessage-params
Merged
Update fetchStatusMessage to handle empty offset / page#1536DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom Daquisu:fix-fetchStatusMessage-params
fetchStatusMessage to handle empty offset / page#1536DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom
Daquisu:fix-fetchStatusMessage-params
Conversation
Contributor
Reviewer's GuideIntroduce default values for Sequence Diagram:
|
| Change | Details | Files |
|---|---|---|
Default offset parameter added to fetchStatusMessage |
|
src/api/services/channel.service.ts |
Default page parameter added to fetchStatusMessage |
|
src/api/services/channel.service.ts |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Contributor
There was a problem hiding this comment.
Hey @Daquisu - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using an undefined value for
offsetorpagewhen callingfetchStatusMessagereturns an Internal Server Error (http code 500) in the API.With the fact that the docs did not mention
offsetandpage, caused some confusion when interacting with this endpoint.This PR adds a default value for both
offsetandpagewhen they are not specified, similar to what is already done in the functionfetchMessages(src/api/services/channel.service.ts)Together with the docs update at EvolutionAPI/docs-evolution#16, it should solve the issues #1253, #1339, and #1533
Summary by Sourcery
Default missing
offsetandpageparameters infetchStatusMessageto prevent unhandled server errorsBug Fixes:
offsetorpageis undefined infetchStatusMessageEnhancements:
fetchMessagesby settingoffsetto 50 andpageto 1 when absent