improv: Ajustado isEmoji para aceitar todos os emojis.#1729
Merged
DavidsonGomes merged 2 commits intoEvolutionAPI:developfrom Jul 21, 2025
ricaelchiquetti:main
Merged
improv: Ajustado isEmoji para aceitar todos os emojis.#1729DavidsonGomes merged 2 commits intoEvolutionAPI:developfrom ricaelchiquetti:main
DavidsonGomes merged 2 commits intoEvolutionAPI:developfrom
ricaelchiquetti:main
Conversation
Contributor
Reviewer's GuideReplaces the handcrafted Unicode regex with the emoji-regex library in isEmoji and enforces that only strings composed of exactly one emoji return true. Class diagram for isEmoji function update in sendMessage.controller.tsclassDiagram
class SendMessageController {
}
class isEmoji {
+boolean isEmoji(str: string)
}
SendMessageController ..> isEmoji : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ricaelchiquetti - I've reviewed your changes - here's some feedback:
- Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
- Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
- Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Este PR melhora a função
isEmojinosendMessage.controller.tspara validar corretamente strings que contêm apenas um emoji. A implementação anterior não deixava ser enviado alguns Emojis.O que foi feito
emoji-regex.trueapenas se a string for exatamente um emoji.Summary by Sourcery
Improve emoji validation in sendMessage.controller by using emoji-regex to ensure only single-emoji strings return true
Enhancements:
Build: