feat: add generic singleton Instance pattern for CustomItem and CustomRole#775
Open
MS-crew wants to merge 1 commit intoExMod-Team:devfrom
Open
feat: add generic singleton Instance pattern for CustomItem and CustomRole#775MS-crew wants to merge 1 commit intoExMod-Team:devfrom
MS-crew wants to merge 1 commit intoExMod-Team:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adds CustomItem, CustomRole and typed wrappers for all subclasses (CustomWeapon, CustomKeycard, CustomArmor, CustomGrenade, CustomGoggles). Instead of fetching instances via Get(id) or Get(name) which are fragile since ids and names can change at any time with configs, other plugins can now reference a custom item or role directly via example MyCustomGoggles.Instance or MyCustomRole.Instance, getting full strongly typed access to all properties and methods without any casting. This makes cross plugin integrations simpler, less error prone, and more accessible to developers who aren't deeply familiar with the codebase.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:

Example usage
on another plugin via referance or another class
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other