fix: chat visibility race condition and persistent fade timers#42
Merged
Extremelyd1 merged 1 commit intoExtremelyd1:mainfrom Mar 19, 2026
Merged
fix: chat visibility race condition and persistent fade timers#42Extremelyd1 merged 1 commit intoExtremelyd1:mainfrom
Extremelyd1 merged 1 commit intoExtremelyd1:mainfrom
Conversation
Extremelyd1
approved these changes
Mar 19, 2026
Owner
Extremelyd1
left a comment
There was a problem hiding this comment.
Nice description of the problem and solution, and clean fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/tpain @BobbyTheCatfish 's case),ChatBox.OnChatSubmitinvokes the command and then immediately callsHideChatInput(). In the previous code,HideChatInput()explicitly calledHide()on every message, which nuked any new addon feedback before it could be rendered.Solution
Hide()loop inHideChatInput()withUpdateMessageVisibility(). This allows the UI to handle visibility state naturally, ensuring that newly added messages remain visible when the input area closes._waitElapsed,_fadeElapsed) to class-level fields. TheFadeRoutinenow correctly pauses when the chat is open and resumes from its exact progress when the chat closes.