Remove CCL compat. #454
Merged
Remove CCL compat. #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin. |
FiniteReality
approved these changes
Feb 7, 2025
Owner
FiniteReality
left a comment
FiniteReality
left a comment
There was a problem hiding this comment.
I'm happy to drop this if you're maintaining it on your end; it just needs the DCO sign-off. The source set stuff is fine for now, I've been meaning to do some refactors anyway.
Author
|
I have read and hereby affirm the entire contents of the Developer Certificate of Origin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Embeddium's currently borked CCL compat.
Not sure what you would like done with the now empty compat source set. Happy to clean this up too if you would like it rolled in here.
Also, happy to cherry-pick this over to the 1.21.4 branch if you would like.
I have decided to maintain this support my side in CCL for 1.21.1.
I have deprecated this entire system in CCL for removal in 1.21.4, whenever that happens. My use cases for the API have been eroded due to improvements vanilla has made to its Lighting engine, resulting in Microblocks working perfectly fine without bypassing the model system. An upcoming release of CBMultipart will ship with baked model support.
Thanks for having compat with CCL :)
Fixes #441