Conversation
…port* port, const TEXT* function, ISC_STATUS operation, int status)
Co-authored-by: Adriano dos Santos Fernandes <529415+asfernandes@users.noreply.github.com>
…ed delete windows end of line mark as \r\n (CR + LF) Otherwise, the file will not be found. more info: ChrisDodd/btyacc#32
…t/firebird into libtommath-update-to-1.2
extern/btyacc/reader.c
Outdated
| inc_file_name[ii] = line[i]; | ||
| } | ||
| inc_file_name[ii] = 0; | ||
|
|
There was a problem hiding this comment.
How is it related with libtommath update? :)
There was a problem hiding this comment.
it is already deleted from this PR
https://github.com/FirebirdSQL/firebird/pull/8917/changes/87cb3693861fcf818b4a61a1345f16f4e81d7bfc/
src/remote/inet.cpp
Outdated
| @@ -3121,6 +3121,8 @@ static bool packet_receive(rem_port* port, UCHAR* buffer, SSHORT buffer_length, | |||
| INET_force_error = 1; | |||
| try | |||
| { | |||
| // function inet_error as 5 parameters | |||
There was a problem hiding this comment.
Please do not put all stuff into single PR.
There was a problem hiding this comment.
This PR was approved earlier.
#8882..
I don't understand why this change was repeated here...
and how to remove it from here :(
There was a problem hiding this comment.
For example create new fresh branch and cherry-pick required commits from this branch.
|
Why 1.2.0 ? AFAIU, latest stable release is 1.3.0 |
in the Linux dockerfile we noticed downloads and compilations on the fly libtommath v1.2.0.
|
Prebuilt linux binaries can use any version of library which is installed in host OS. Yes, docker is using 1.2, but it makes no difference for the rest of platforms.
Gentoo stable (known with it's careful approach of choosing really stable versions) is using 1.3.0. I agree with Vlad - let's upgrade to it. |
|
Okay, but we need to test again for 1.3 ... |
|
Libtommath update to 1.3.0 |
3 participants
update *.c and *.h files in source tree extern\libtommath
to to https://github.com/libtom/libtommath/releases/tag/v1.2.0
cross-platform compilation error patch (lilke win only patch https://github.com/microsoft/vcpkg/blob/master/ports/libtommath/msvc-dce.patch)
update *.c and *.h file list in MSVC15.vcxproj (need for build-windows)
update *.o file list in makefiles (need for build-apline)