fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447
fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Docker builds report
|
docs/docs/administration-and-security/data-management/import-from-launchdarkly.md
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
==========================================
+ Coverage 98.22% 98.23% +0.01%
==========================================
Files 1313 1311 -2
Lines 47481 48479 +998
==========================================
+ Hits 46636 47622 +986
- Misses 845 857 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
601ab7f to
fdcec4b
Compare
fdcec4b to
cff70ec
Compare
Zaimwa9
left a comment
There was a problem hiding this comment.
Looks good. I have one comment about the expiry that can lead to some a bit annoying UX.
And just putting it on the radar. I wouldn't do it in this PR and it doesn't look very prio but because the archived flag relies on a boolean flag (and not a tag as the other). We can not filter on deprecated alone.
We need to filter on both archived (to have the boolean) and deprecated to see them
Great catch. I'd say this PR introduces poor UX without this addressed, or at least documented as a new issue. However, I don't see a good solution to be coupling the |
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
I've decided to remove the newly introduced "Deprecated" tag entirely, see e5ab999. Although it looks helpful upfront, it also creates an UX problem we don't need IMO. |
Zaimwa9
left a comment
There was a problem hiding this comment.
👍 Thanks. Good call I think for now to keep both of them archived. Hopefully it's sufficient for customers
Import deprecated flags from LaunchDarkly as archived features in Flagsmith.
Changes
I was also very annoyed that there is no user feedback after importing, and came to an improvement I like:
or
Closes #5642
Review effort: 2/5