Skip to content

fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447

Merged
emyller merged 5 commits intomainfrom
fix/ld-importer/archive-deprecated-flags
Feb 17, 2026
Merged

fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447
emyller merged 5 commits intomainfrom
fix/ld-importer/archive-deprecated-flags

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Dec 30, 2025

Import deprecated flags from LaunchDarkly as archived features in Flagsmith.

Changes

  • Archive deprecated flags on import.
  • Removed white text from "importing" overlay — it was very hard to read, and not useful.

I was also very annoyed that there is no user feedback after importing, and came to an improvement I like:

image

or

image

Closes #5642

Review effort: 2/5

@emyller emyller requested review from a team as code owners December 30, 2025 20:50
@emyller emyller requested review from adamvialpando and khvn26 and removed request for a team December 30, 2025 20:50
@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 17, 2026 3:17pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Preview Feb 17, 2026 3:17pm
flagsmith-frontend-staging Ignored Ignored Preview Feb 17, 2026 3:17pm

Request Review

@emyller emyller self-assigned this Dec 30, 2025
@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates fix and removed docs Documentation updates labels Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6447 Finished ✅ Results

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (cf16f3d) to head (e5ab999).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6447      +/-   ##
==========================================
+ Coverage   98.22%   98.23%   +0.01%     
==========================================
  Files        1313     1311       -2     
  Lines       47481    48479     +998     
==========================================
+ Hits        46636    47622     +986     
- Misses        845      857      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the fix/ld-importer/archive-deprecated-flags branch from 601ab7f to fdcec4b Compare December 31, 2025 03:23
@github-actions github-actions bot added the docs Documentation updates label Dec 31, 2025
@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Dec 31, 2025
khvn26
khvn26 previously approved these changes Jan 1, 2026
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added docs Documentation updates fix and removed fix docs Documentation updates labels Feb 6, 2026
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one comment about the expiry that can lead to some a bit annoying UX.
And just putting it on the radar. I wouldn't do it in this PR and it doesn't look very prio but because the archived flag relies on a boolean flag (and not a tag as the other). We can not filter on deprecated alone.

We need to filter on both archived (to have the boolean) and deprecated to see them

Image Image

@emyller
Copy link
Contributor Author

emyller commented Feb 16, 2026

We need to filter on both archived (to have the boolean) and deprecated to see them

Great catch. I'd say this PR introduces poor UX without this addressed, or at least documented as a new issue. However, I don't see a good solution to be coupling the Deprecated tag and archived state together... Maybe the tag filter should include features regardless of their "archived" state if that makes sense. Let's discuss internally.

@cursor
Copy link

cursor bot commented Feb 17, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@github-actions github-actions bot added docs Documentation updates fix and removed fix docs Documentation updates labels Feb 17, 2026
@emyller
Copy link
Contributor Author

emyller commented Feb 17, 2026

We need to filter on both archived (to have the boolean) and deprecated to see them

Great catch. I'd say this PR introduces poor UX without this addressed, or at least documented as a new issue. However, I don't see a good solution to be coupling the Deprecated tag and archived state together... Maybe the tag filter should include features regardless of their "archived" state if that makes sense. Let's discuss internally.

I've decided to remove the newly introduced "Deprecated" tag entirely, see e5ab999. Although it looks helpful upfront, it also creates an UX problem we don't need IMO.

@emyller emyller requested a review from Zaimwa9 February 17, 2026 16:33
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks. Good call I think for now to keep both of them archived. Hopefully it's sufficient for customers

@emyller emyller merged commit f8cbc64 into main Feb 17, 2026
48 of 54 checks passed
@emyller emyller deleted the fix/ld-importer/archive-deprecated-flags branch February 17, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LD Importer: Tag deprecated flags as archived when importing into Flagsmith

4 participants

Comments