Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3464066 to
31de36b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6663 +/- ##
==========================================
+ Coverage 98.20% 98.23% +0.02%
==========================================
Files 1298 1312 +14
Lines 47108 48503 +1395
==========================================
+ Hits 46262 47646 +1384
- Misses 846 857 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Docker builds report
|
Zaimwa9
left a comment
There was a problem hiding this comment.
I'd like to confirm that the difference i'm seeing on the error message display is not due to our local setups somehow
| switch (detail) { | ||
| case 'Not found.': | ||
| return 'We could not validate your invite, please check the invite URL and email address you have entered is correct.' | ||
| case 'Please upgrade your plan to add additional seats/users': |
There was a problem hiding this comment.
Also I'm realising this will not work with invitation from link.
I am not sure whether it's on purpose as there is a disabled flag verify_seats_limit_for_invite_links used in account-store.controller.acceptInvite.
If we try to join an organisation via link while max seats have been reached the error from the link request gets overridden by the one from users/join/id that will return the No Invite matches the given query:
acceptInvite: (id) => {
store.saving()
API.setInvite('')
API.setInviteType('')
return data
.post(`${Project.api}users/join/link/${id}/`)
.catch((error) => {
console.log('error-ajax', error)
if (
Utils.getFlagsmithHasFeature('verify_seats_limit_for_invite_links') &&
error.status === 400
) {
API.ajaxHandler(store, error)
return // Here it should throw too otherwise below res.id is undefined and crash the app
}
return data.post(`${Project.api}users/join/${id}/`)
})
Then I don't know if this is the way self-hosted are supposed to invite their members
There was a problem hiding this comment.
As per discussion, and manual testing, I think this is now resolved in e87994c.
Changes
Enforces seat limits for self-hosted deployments.
Required changes:
Contributes to flagsmith/flagsmith-private#105 and https://github.com/Flagsmith/infrastructure/issues/267
How did you test this code?
Ran the FE locally to verify the FE changes. Added / updated unit tests to verify API changes.