Merged
Conversation
Member
Alkarex
commented
Jan 18, 2026
Alkarex
commented
- Fixes before phpstan2 simplepie/simplepie#957
Currently, we only use these to test code paths that do not involve parsing but it would be nice to be able to reuse the tests for other simple tests. Unfortunately, `Parser::parse` will actually fail with `error_string == "Unknown"`. That is because `xml_get_error_code()` returns 201, which is not one of XML_ERROR_* codes: https://www.php.net/manual/en/xml.error-codes.php It looks like it is actually `XML_NS_ERR_UNDEFINED_NAMESPACE` leaking from libxml2. I can confirm it with `libxml_use_internal_errors(true);` and dumping `libxml_get_errors()`: Namespace prefix media on thumbnail is not defined Since we never use it anywhere, we can just drop the element.
- Improve typing and fix issues that will trip up PHPStan 2.0. - Fix insufficient regex escaping in `SimplePie::get_links()`. - Add editor config for .neon files. - Add PHPStan results cache to .gitignore. - Check our PHPStan extension. - Use `assertNull` in tests instead of `assertSame`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.