Repository navigation
fix: extract Shopmon integration management and adopt legacy credentials - #494
Merged
Merged
Conversation
shyim
marked this pull request as ready for review
October 23, 2026 18:16
Contributor
[Medium impact] The changes since the previous review appear safe to merge. SummaryMoves Shopmon setup, status, and removal into
Since the previous review, the only change extracts the existing permissions list into
|
Member
Author
|
@frosh-ci fix-cs |
Contributor
|
Code style has been fixed and pushed to the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Shopmon integration management from the controller into
ShopmonIntegrationService. Installation and updates refresh the dedicated ACL role and create an integration automatically when bothSHOPMON_ACCESS_KEYandSHOPMON_ACCESS_SECRETare set.Adopt existing FroshShopmon integrations and their stored setup data without rotating credentials or creating duplicates. Repeated manual setup also preserves credentials. Removal cleans up the integration, role, and configuration for both plugins.
The README documents environment setup and the requirement to keep user data when uninstalling FroshShopmon, whose uninstall routine otherwise deletes the adopted integration.
Validation: full PHP suite passed on Shopware 6.7 / PHP 8.3: 439 tests, 5,066 assertions, one skipped. Includes regression coverage for legacy adoption, credential preservation, ACL updates, environment-based setup, malformed configuration, and removal.