Repository navigation
Conversation
cbc8936 to
28c5381
Compare
[Medium impact] The PR appears safe to merge based on the reviewed changes. SummaryAdds an account inventory endpoint for external monitoring.
No actionable new issues were established. Both earlier, unnumbered findings are addressed in the current code. Reviews (3) · Last reviewed commit: "feat: add masked e-mail to admin account..." · Reviewed by Greptile |
|
@schneider-felix what do you think here. For me it feels little bit like useless if we canot say which excactly admin user got created and so on 🙈 |
A UUID alone is useless once the row is gone: monitoring can report that an admin account disappeared, but nobody can tell which one. The star count is fixed at three per part, so the real length stays hidden - combined with the shop's publicly known mail domain it would often be enough to reconstruct the address.
|
I don't think the credential stuffing problem would be too bad but the concern is definitly valid. Here's my wild idea, how we could solve it: On the other hand: I think if shopmon get compromised, credential stuffing is the least of our concerns 😅 |
|
Or, why don't we just send a webhook to shopmon? |
Adds GET /api/_action/frosh-tools/security/accounts behind frosh_tools_security:read, listing admin users, integrations and ACL roles so Shopmon can diff snapshots and alert on new accounts or privilege escalation.
Exposes ids and security relevant attributes only - no usernames, names, e-mail addresses or access keys. Aggregated across many shops those would form a credential stuffing list, so accounts are resolved to a person via the returned adminPath instead. Read via DBAL so no personal column is loaded in the first place.
App integrations report the ACL role attached through app.acl_role_id, which Shopware resolves with precedence over integration_role.