[FIX] Properly account for property access from outside the class #335
+41
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Before I forget it, merging this will cause a crash on Freeplay when the BF cartoon cycle starts since the script tries to modify a scripted final (which should not be allowed), and this PR accidentally fixes that never giving an error. The BF DJ code has to be changed to account for this. |
AbnormalPoof
force-pushed
the
fix/outer-prop
branch
from
693181a to
decba42
Compare
AbnormalPoof
approved these changes
Feb 11, 2026
Member
AbnormalPoof
left a comment
AbnormalPoof
left a comment
There was a problem hiding this comment.
Tested with the repro code in the issue, works great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308
Fixes accessing a variable of a class, from another class, not accounting for properties correctly.
There's repro code in the linked issue.