Remove unused declarations and const-related lint debt

eslint.config.mjs

@@ -97,6 +97,11 @@ export default tseslint.config(
     rules: {
       ...recommendedTypeScriptWarnings,
       "no-restricted-syntax": ["error", noUnboundRxjsOperatorRule],
+      // GSA/sam-ui-elements#585: promoted to errors once the codebase reached
+      // zero warnings for these two rules (unused declarations/imports/params
+      // and never-reassigned `let` bindings are fully cleaned up).
+      "prefer-const": "error",
+      "@typescript-eslint/no-unused-vars": "error",
     },
   },
   {

src/formly/components/autocomplete/autocomplete.component.ts

@@ -4,7 +4,7 @@ import {
   ViewChild,
   ChangeDetectorRef,
 } from "@angular/core";
-import { SamAutocompleteComponent, AutocompleteService } from "../../../ui-kit";
+import { SamAutocompleteComponent } from "../../../ui-kit";
 
 import { AbstractSamFormly } from "../../sam-formly";
 

src/formly/components/autocomplete/test.service.ts

@@ -8,6 +8,7 @@ export class TestAutocompleteService implements AutocompleteService {
   public setFetchMethod() {}
 
   public fetch(val: string): Observable<unknown> {
+    void val;
     return of([
       { key: "MD", value: "Maryland", category: "Places" },
       { key: "VA", value: "Virginia", category: "Places" },

src/ui-kit/components/accordion/accordion.spec.ts

@@ -1,7 +1,6 @@
 import {
   waitForAsync,
   ComponentFixtureAutoDetect,
-  ComponentFixture,
   TestBed,
 } from "@angular/core/testing";
 import { Component } from "@angular/core";
@@ -58,7 +57,7 @@
 })
 class AccordionInitialized {}
 
 function getComponent(fix: any) {
   return fix.debugElement.query(By.directive(SamAccordionComponent))
     .componentInstance;
 }
@@ -67,19 +66,18 @@
   describe("isolated tests", () => {
     let component: SamAccordionComponent;
     let sectionComponent: SamAccordionSection;
-    let sectionComponent2: SamAccordionSection;
     beforeEach(() => {
       component = new SamAccordionComponent();
       sectionComponent = new SamAccordionSection(component);
-      sectionComponent2 = new SamAccordionSection(component);
+      new SamAccordionSection(component);
     });
     // section
     it('should check for "name" prop and throw error', () => {
       try {
         sectionComponent.ngOnInit();
         // shouldn't get here
         expect(false).toBe(true);
-      } catch (e) {
+      } catch {
         expect(true).toBe(true);
       }
     });
@@ -127,7 +125,7 @@
 
   describe("integration tests", () => {
     let component: SamAccordionComponent;
     let fixture: any;
 
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({

src/ui-kit/components/actions/action-button/action-button.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, Output, EventEmitter, OnInit } from "@angular/core";
+import { Component, Input, Output, EventEmitter } from "@angular/core";
 import { SamActionInterface } from "../action-interface";
 
 @Component({
@@ -18,11 +18,11 @@
   /**
    * EventEmitter that emits action name when button is clicked
    */
   @Output() emitAction: EventEmitter<any> = new EventEmitter<any>();
   /**
    * Emits the results of the callback
    */
   @Output() emitCallback: EventEmitter<any> = new EventEmitter<any>();
 
   actionClicked() {
     this.emitCallback.emit(this.action.callback());

src/ui-kit/components/actions/actions-dropdown/actions-dropdown.component.ts

@@ -4,7 +4,6 @@ import {
   Output,
   EventEmitter,
   ViewChild,
-  ElementRef,
   ViewChildren,
 } from "@angular/core";
 
@@ -55,7 +54,8 @@ export class SamActionsDropdownComponent {
   showActions = false;
   focusIndex = -1;
 
-  hideActions(event) {
+  hideActions(event: Event) {
+    void event;
     return (this.showActions = false);
   }
 
@@ -88,7 +88,7 @@ export class SamActionsDropdownComponent {
   }
 
   setFocusOnFirstItem() {
-    this.actionsList.changes.subscribe((t) => {
+    this.actionsList.changes.subscribe(() => {
       this.ngForRendered();
     });
   }

src/ui-kit/components/alert-footer/alert-footer.service.ts

@@ -1,4 +1,4 @@
-import { Component, Injectable } from "@angular/core";
+import { Injectable } from "@angular/core";
 import { AlertType } from "../../types";
 @Injectable()
 export class SamAlertFooterService {

src/ui-kit/components/alert-footer/alert-footer.spec.ts

@@ -1,18 +1,15 @@
 import { TestBed, inject } from "@angular/core/testing";
-import { Observable } from "rxjs";
-import { By } from "@angular/platform-browser";
 
 // Load the implementations that should be tested
 import { SamAlertFooterComponent, SamAlertFooterService } from "./index";
 import { SamAlertComponent } from "../alert/alert.component";
 
 describe("The AlertFooter component", () => {
   describe("isolated tests", () => {
-    let component: SamAlertFooterComponent;
     let service: SamAlertFooterService;
     beforeEach(() => {
       service = new SamAlertFooterService();
-      component = new SamAlertFooterComponent(service);
+      new SamAlertFooterComponent(service);
       service.registerFooterAlert({
         description: "hello",
         title: "alert title",

src/ui-kit/components/alert/alert.spec.ts

@@ -1,7 +1,6 @@
 import { TestBed } from "@angular/core/testing";
 import { RouterTestingModule } from "@angular/router/testing";
 import { By } from "@angular/platform-browser";
-import { SimpleChanges } from "@angular/core";
 
 // Load the implementations that should be tested
 import { SamAlertComponent } from "./alert.component";

src/ui-kit/components/banner/banner.spec.ts

@@ -1,5 +1,4 @@
 import { TestBed } from "@angular/core/testing";
-import { By } from "@angular/platform-browser";
 
 // Load the implementations that should be tested
 import { SamBannerComponent } from "./banner.component";

src/ui-kit/components/breadcrumbs/breadcrumbs.component.ts

@@ -1,5 +1,4 @@
 import { Component, Input, Output, EventEmitter } from "@angular/core";
-import { NavigationEnd, UrlSegment } from "@angular/router";
 import { IBreadcrumb } from "../../types";
 
 @Component({

src/ui-kit/components/breadcrumbs/breadcrumbs.spec.ts

@@ -1,8 +1,6 @@
 import { TestBed } from "@angular/core/testing";
 import { By } from "@angular/platform-browser";
 import { RouterTestingModule } from "@angular/router/testing";
-import { Observable, Subject } from "rxjs";
-import { ActivatedRoute } from "@angular/router";
 
 // Load the implementations that should be tested
 import { SamBreadcrumbsComponent } from "./breadcrumbs.component";

src/ui-kit/components/comments/comment/comment.component.ts

@@ -21,7 +21,7 @@ export class SamCommentComponent {
    */
   @Output() delete: EventEmitter<any> = new EventEmitter<any>();
 
-  emitClick(comment: Event) {
+  emitClick() {
     this.delete.emit(this.comment);
   }
 }

src/ui-kit/components/comments/comment/comment.spec.ts

@@ -1,5 +1,4 @@
 import { TestBed } from "@angular/core/testing";
-import { CommonModule } from "@angular/common";
 import moment from "moment";
 import { By } from "@angular/platform-browser";
 

src/ui-kit/components/comments/comments.component.ts

@@ -2,17 +2,11 @@ import {
   Component,
   Input,
   OnInit,
-  Optional,
   ViewChild,
   ElementRef,
   OnDestroy,
 } from "@angular/core";
-import {
-  FormBuilder,
-  FormGroup,
-  Validators,
-  ControlValueAccessor,
-} from "@angular/forms";
+import { FormBuilder, FormGroup, Validators } from "@angular/forms";
 
 import { Observable, Subscription, Subject, of, fromEvent } from "rxjs";
 import { flatMap, catchError, merge } from "rxjs/operators";
@@ -103,15 +97,15 @@ export class SamCommentsComponent implements OnInit, OnDestroy {
 
     // Map DOM events to actions
     this.getCommentsStream = this.showButtonStream.pipe(
-      flatMap((event) => {
+      flatMap(() => {
         return this.commentsService
           .getComments()
           .pipe(catchError((error) => of(error)));
       })
     );
 
     this.collapseCommentsStream = this.hideCommentsStream.pipe(
-      flatMap((event) => {
+      flatMap(() => {
         return this.commentsService
           .getInitialState()
           .pipe(catchError((error) => of(error)));

src/ui-kit/components/comments/comments.module.ts

@@ -4,7 +4,6 @@ import { FormsModule, ReactiveFormsModule } from "@angular/forms";
 
 import { SamCommentsComponent } from "./comments.component";
 import { SamCommentComponent } from "./comment";
-import { CommentsService } from "./comments.service";
 
 import { SamPipesModule } from "../../pipes";
 import { SamTextAreaModule } from "../../form-controls/textarea";

src/ui-kit/components/comments/comments.service.ts

@@ -12,6 +12,7 @@ export class CommentsService {
   }
 
   isCommentDeletable(comment: Comment): boolean {
+    void comment;
     return true;
   }
 
@@ -23,11 +24,13 @@ export class CommentsService {
     return of(this._comments);
   }
 
-  postComment(_: any): Observable<Comment[]> {
+  postComment(comment: Comment): Observable<Comment[]> {
+    void comment;
     return of(this._comments);
   }
 
   deleteComment(comment: Comment): Observable<Comment[]> {
+    void comment;
     return of(this._comments);
   }
 

src/ui-kit/components/comments/comments.spec.ts

@@ -9,7 +9,6 @@ import {
   CommentsService,
   Comment,
 } from "./";
-import { SamPipesModule } from "../../pipes";
 
 import { Observable, of, throwError } from "rxjs";
 
@@ -88,7 +87,7 @@ export class CommentsDemoService implements CommentsService {
     return this._disabled;
   }
 
-  isCommentDeletable(comment: Comment): boolean {
+  isCommentDeletable(): boolean {
     return true;
   }
 
@@ -126,11 +125,10 @@ export class CommentsDemoService implements CommentsService {
 
 describe("The Sam Comments component", () => {
   describe("isolated tests", () => {
-    let component: SamCommentsComponent;
     let service: CommentsService;
     beforeEach(() => {
       service = new CommentsService();
-      component = new SamCommentsComponent(service, undefined);
+      new SamCommentsComponent(service, undefined);
     });
     // service
     it("service should tell us if commenting is disabled", () => {

src/ui-kit/components/data-table/data-source.sample.spec.ts

@@ -2,7 +2,6 @@ import { SamSortable, SamSortDirective } from "./";
 import { merge } from "rxjs";
 import { map } from "rxjs/operators";
 import { DataSource } from "@angular/cdk/collections";
-import { fromEvent } from "rxjs";
 import { RECORDS } from "./data.sample.spec";
 import { BehaviorSubject } from "rxjs";
 /* tslint:disable */

src/ui-kit/components/data-table/data-table.component.ts

@@ -6,15 +6,10 @@ import {
   Input,
   OnChanges,
 } from "@angular/core";
-import {
-  CdkTable,
-  STICKY_POSITIONING_LISTENER,
-  CDK_TABLE,
-} from "@angular/cdk/table";
+import { CdkTable, CDK_TABLE } from "@angular/cdk/table";
 
 import {
   _DisposeViewRepeaterStrategy,
-  _RecycleViewRepeaterStrategy,
   _VIEW_REPEATER_STRATEGY,
 } from "@angular/cdk/collections";
 
@@ -83,9 +78,3 @@ export class SamDataTableComponent<T>
     }
   }
 }
-function Directive(arg0: {
-  selector: string;
-  providers: { provide: any; useClass: any }[];
-}) {
-  throw new Error("Function not implemented.");
-}

src/ui-kit/components/download/download.spec.ts

@@ -1,7 +1,6 @@
 import { TestBed, ComponentFixture } from "@angular/core/testing";
 import { By } from "@angular/platform-browser";
 import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
-import { DebugElement } from "@angular/core";
 import { AccessType, ExpansionType } from "../../types";
 import { SamDownloadComponent } from "./download.component";
 

src/ui-kit/components/footer-next/footer-nav-item.component.ts

@@ -1,4 +1,4 @@
-import { Component, Host } from "@angular/core";
+import { Component } from "@angular/core";
 
 @Component({
   selector: "sam-footer-nav-item",

src/ui-kit/components/header-next/header.component.ts

@@ -31,7 +31,7 @@ export class SamHeaderNextComponent {
   // we know the user's viewport has been resized to be larger.
   // Let's make the page state consistent by deactivating the mobile nav.
   @HostListener("window:resize", ["$event"])
-  onBrowserResize(event) {
+  onBrowserResize() {
     if (
       this.mobileNavActive &&
       this.closeNavBtn.nativeElement.getBoundingClientRect().width === 0

src/ui-kit/components/header/header.component.spec.ts

@@ -21,7 +21,6 @@ describe("The Sam Header component", () => {
   });
 
   describe("rendered test", () => {
-    let component: SamHeaderComponent;
     let fixture: any;
 
     // provide our implementations or mocks to the dependency injector
@@ -31,7 +30,6 @@ describe("The Sam Header component", () => {
         declarations: [SamHeaderComponent],
       });
       fixture = TestBed.createComponent(SamHeaderComponent);
-      component = fixture.componentInstance;
     });
 
     it("should compile", function () {

src/ui-kit/components/history/history.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, waitForAsync } from "@angular/core/testing";
+import { TestBed } from "@angular/core/testing";
 
 import { By } from "@angular/platform-browser";
 import { RouterTestingModule } from "@angular/router/testing";

src/ui-kit/components/image/image.component.ts

@@ -74,7 +74,7 @@ export class SamImageComponent implements OnInit {
     this.editModeSubscription = this.editButtonStream
       .pipe(merge(this.cancelButtonStream), merge(this.saveButtonStream))
       .subscribe(
-        (event) => {
+        () => {
           if (this.editable) {
             this.toggleEdit();
           }
@@ -85,7 +85,7 @@ export class SamImageComponent implements OnInit {
       );
 
     this.cancelButtonSubscription = this.cancelButtonStream.subscribe(
-      (event) => {
+      () => {
         this.tmpValue = undefined;
         this.tmpSrc = undefined;
       },
@@ -95,7 +95,7 @@ export class SamImageComponent implements OnInit {
     );
 
     this.saveButtonSubscription = this.saveButtonStream.subscribe(
-      (event) => {
+      () => {
         if (this.isImageTemporary()) {
           this.value = this.tmpValue;
           this.src = this.tmpSrc;

src/ui-kit/components/multiselect-dropdown/multiselect-dropdown.spec.ts

@@ -1,7 +1,6 @@
 import { TestBed } from "@angular/core/testing";
 
 import { SamMultiSelectDropdownComponent } from "./multiselect-dropdown.component";
-import { SamUIKitModule } from "../../index";
 import { SamFormControlsModule } from "../../form-controls";
 import { SamFormService } from "../../form-service";
 

src/ui-kit/components/page-title/page-title.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, HostBinding } from "@angular/core";
+import { Component, Input } from "@angular/core";
 
 @Component({
   selector: "sam-page-title",

src/ui-kit/components/pagination/pagination.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, waitForAsync, fakeAsync, tick } from "@angular/core/testing";
+import { TestBed } from "@angular/core/testing";
 
 import { By } from "@angular/platform-browser";
 

src/ui-kit/components/point-of-contact/point-of-contact.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, waitForAsync, fakeAsync, tick } from "@angular/core/testing";
+import { TestBed } from "@angular/core/testing";
 
 import { By } from "@angular/platform-browser";