add support for partial draining of things like gt cells#87
Closed
chrombread wants to merge 1 commit intomasterfrom
Closed
add support for partial draining of things like gt cells#87chrombread wants to merge 1 commit intomasterfrom
chrombread wants to merge 1 commit intomasterfrom
Conversation
Dream-Master
added
the
🚧 Testing on Zeta
Member
|
I'm working on a fluid handling refactoring PR that's going to supersede this PR, so it doesn't need to be reviewed right now |
Member
|
Done: #93 |
Member
Author
|
this can be closed since it's superseded. |
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://discord.com/channels/181078474394566657/522098956491030558/1457456489638658048
the rest of the code was copied from mui1 when it was written, but not this part for some reason. maybe it was implemented at a later point in time? see https://github.com/GTNewHorizons/ModularUI/blob/master/src/main/java/com/gtnewhorizons/modularui/common/widget/FluidSlotWidget.java#L446
either way, tested in game and it seems to work with gt cells.