getContainerForFilledItem return null when container.drain returns null#88
Merged
Dream-Master merged 1 commit intomasterfrom Jan 8, 2026
Merged
getContainerForFilledItem return null when container.drain returns null#88Dream-Master merged 1 commit intomasterfrom
Dream-Master merged 1 commit intomasterfrom
Conversation
danyadev
reviewed
Jan 8, 2026
src/main/java/com/cleanroommc/modularui/utils/fluid/FluidInteractions.java
Show resolved
Hide resolved
danyadev
approved these changes
Jan 8, 2026
Member
danyadev
left a comment
danyadev
left a comment
There was a problem hiding this comment.
alright it can't hurt and should fix at least some cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IFluidContainerItem.drain returns null in certain cases, indicating that the drain failed. So getContainerForFilledItem should return null when this happens.
fixes GTNewHorizons/GT-New-Horizons-Modpack#23153