Fixed error handling in MetabolicNetwork.from_sbml#112
Open
AdityaTaggar05 wants to merge 1 commit intoGeomScale:developfrom
Open
Fixed error handling in MetabolicNetwork.from_sbml#112AdityaTaggar05 wants to merge 1 commit intoGeomScale:developfrom
AdityaTaggar05 wants to merge 1 commit intoGeomScale:developfrom
Conversation
AdityaTaggar05
changed the title
vfisikop
approved these changes
Apr 4, 2025
vfisikop
left a comment
vfisikop
left a comment
There was a problem hiding this comment.
Thanks! Would you like to also add some tests for those exceptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, using an 'and' clause raised a TypeError when passing in a non-subscriptable data type; hence, the desired Exception was not raised. Due to the usage of 'or' clause in other '.from_' methods, it only checked the datatype and did not check the subscriptable nature, and raised the correct Exception. The image below demonstrates it.