Fix reading messages from muted users #1063
Merged
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
commented
Dec 3, 2025
| } | ||
|
|
||
| private func sendReadEventIfNeeded(for message: ChatMessage) { | ||
| guard let channel, channel.unreadCount.messages > 0 else { |
Contributor
Author
There was a problem hiding this comment.
Since unread count did not change when a muted user sent a message then we never called mark read
Member
There was a problem hiding this comment.
Do we have the same issue on UIKit? I think I introduced this logic recently in UIKit as well 🤔
Contributor
Author
There was a problem hiding this comment.
The same bug reproduces on UIKit as well.
martinmitrevski
approved these changes
Dec 3, 2025
nuno-vieira
approved these changes
Dec 3, 2025
# Conflicts: # CHANGELOG.md
Public Interface🚀 No changes affecting the public interface. |
|
Collaborator
SDK Size
|
Collaborator
StreamChatSwiftUI XCSize
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes: IOS-1238
🎯 Goal
Fix reading messages from muted users
📝 Summary
🧪 Manual Testing Notes
The message status is read and delivered
☑️ Contributor Checklist
docs-contentrepo