fix: rpc fallback needs to check both exception and nested error

[L03TJ3]

Description

Noticed on dev server. if the exception of RPC is root exception and not in exception.error the fallback does not catch it properly and stops cycling through other RPC providers in the list.

Summary by Sourcery

Bug Fixes:

• Ensure connection errors are detected from either the nested error field or the root exception so failing providers do not block fallback to other RPC endpoints.

[sourcery-ai]

Hey - I've left some high level feedback:

• When falling back to exception in isConnectionError(error || exception), consider using a nullish-coalescing check (e.g., error ?? exception) and guarding for non-object/non-Error values so that truthy but non-informative error values (like an empty string or boolean) don't mask a more useful exception message.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When falling back to `exception` in `isConnectionError(error || exception)`, consider using a nullish-coalescing check (e.g., `error ?? exception`) and guarding for non-object/non-Error values so that truthy but non-informative `error` values (like an empty string or boolean) don't mask a more useful exception message.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}