Skip to content

core: set NetworkRequest.renderBlocking from CDP data - #16869

Open
iamakulov wants to merge 1 commit into
GoogleChrome:mainfrom
iamakulov:core/cdp-render-blocking
Open

iamakulov wants to merge 1 commit into
GoogleChrome:mainfrom
iamakulov:core/cdp-render-blocking

Conversation

@iamakulov

Copy link
Copy Markdown

Summary

This is a sibling PR to https://chromium-review.googlesource.com/c/chromium/src/+/7269488 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7262577. It drills the renderBlockingBehavior flag introduced in the former, and makes it available to core Lantern login in the latter.

The practical impact of this is that FCP and LCP start using more accurate render-blocking data (starting with M145).

Related Issues/PRs

#16539

@iamakulov
iamakulov requested a review from a team as a code owner January 28, 2026 21:37
@iamakulov
iamakulov requested review from connorjclark and removed request for a team January 28, 2026 21:37
@iamakulov
iamakulov force-pushed the core/cdp-render-blocking branch from 42e1d82 to 3101992 Compare January 28, 2026 21:38

@paulirish paulirish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thank you

Comment thread core/lib/network-request.js Outdated
const HEADER_PROTOCOL_IS_H2 = 'X-ProtocolIsH2';

// CDP uses PascalCase (M145+), Lantern uses snake_case.
/** @type {Record<LH.Crdp.Network.RenderBlockingBehavior, Lantern.Types.RenderBlocking>} */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamakulov

Copy link
Copy Markdown
Author

(Heads-up that I don't have collaborator permissions so you folks need to merge this one yourself :)

@iamakulov
iamakulov force-pushed the core/cdp-render-blocking branch from 55c502a to 7154132 Compare July 30, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants