feat(email): migrate email digest renderer to CategorizedSummaryVisitor (#2622)#2635
Open
jcscottiii wants to merge 1 commit into
Open
Conversation
jcscottiii
force-pushed
the
feat/all-saved-search-rss-visitor-impl
branch
from
July 21, 2026 20:05
6c9623f to
cf06012
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 20:05
1d9efae to
39bcf5b
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-rss-visitor-impl
branch
from
July 21, 2026 20:10
cf06012 to
fd0471d
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
2 times, most recently
from
July 21, 2026 21:10
3089994 to
c868c76
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-rss-visitor-impl
branch
from
July 21, 2026 21:10
fd0471d to
60a4463
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 21, 2026 21:43
c868c76 to
b349e90
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-rss-visitor-impl
branch
2 times, most recently
from
July 22, 2026 14:01
b1995de to
ea868e5
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 22, 2026 14:01
b349e90 to
0b5de95
Compare
…or (#2622) Migrate the email digest template generator to the CategorizedSummaryVisitor interface for double-dispatch rendering. - Implement CategorizedSummaryVisitor on templateDataGenerator in workers/email/pkg/digest, routing categorized highlights into email template data. - Wire trigger filtering and highlight categorization through EventSummary.Accept(). - Add a golden HTML snapshot test (digest_combined_errors_and_features.golden.html) covering combined query error banners and feature change sections. - Add Makefile and .prettierignore entries for the new golden HTML snapshot test file. CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1 TAG=agy
jcscottiii
force-pushed
the
feat/all-saved-search-rss-visitor-impl
branch
from
July 22, 2026 14:58
ea868e5 to
dce0111
Compare
jcscottiii
force-pushed
the
feat/all-saved-search-email-visitor-impl
branch
from
July 22, 2026 14:58
0b5de95 to
b134ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the email digest template generator to the CategorizedSummaryVisitor interface for double-dispatch rendering.
Fixes #2622 (PR 3/5)
CONV=f70d8c59-6f49-4a69-bb74-5643e908f5b1
TAG=agy