Skip to content

feat: reintroduce finalize-file-for-rapid as deprecated alias#4684

Open
vipnydav wants to merge 1 commit into
masterfrom
reintroduce-finalize-file-for-rapid
Open

feat: reintroduce finalize-file-for-rapid as deprecated alias#4684
vipnydav wants to merge 1 commit into
masterfrom
reintroduce-finalize-file-for-rapid

Conversation

@vipnydav
Copy link
Copy Markdown
Member

Description

This PR reintroduces the finalize-file-for-rapid flag as a deprecated and hidden alias for the new finalize-file-on-close flag. This ensures that users who were previously instructed to use the rapid-specific flag do not experience breaking changes.

Link to the issue in case of a bug fix.

Testing details

  1. Manual - Done
  2. Unit tests - Added
  3. Integration tests - Automated

Any backward incompatible change? If so, please explain.

@vipnydav vipnydav requested a review from vadlakondaswetha May 12, 2026 05:50
@vipnydav vipnydav requested a review from a team as a code owner May 12, 2026 05:50
@vipnydav vipnydav added execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels May 12, 2026
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label May 12, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures backward compatibility for users relying on the 'finalize-file-for-rapid' flag by reintroducing it as a deprecated and hidden alias for 'finalize-file-on-close'. The changes include updating the configuration schema, command-line flag definitions, and adding a mapping mechanism to handle the transition gracefully without breaking existing workflows.

Highlights

  • Deprecated Flag Reintroduction: Reintroduced the 'finalize-file-for-rapid' flag as a hidden, deprecated alias for 'finalize-file-on-close' to maintain backward compatibility.
  • Configuration Mapping: Implemented logic in the root command to map the deprecated flag value to the new configuration setting if the latter is not explicitly set.
  • Testing: Added unit tests to verify the fallback behavior and ensure that the new flag takes precedence over the deprecated one.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the finalize-file-for-rapid flag as a deprecated alias for finalize-file-on-close, including mapping logic in the root command and corresponding test cases to ensure correct precedence. A critical review point notes that cfg/config.go is a generated file and should not be modified manually; instead, the source cfg/params.yaml should be updated and the configuration code should be regenerated.

Comment thread cfg/config.go
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.74%. Comparing base (9d99755) to head (4a4cfb3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4684      +/-   ##
==========================================
- Coverage   83.74%   83.74%   -0.01%     
==========================================
  Files         165      165              
  Lines       20497    20501       +4     
==========================================
+ Hits        17166    17169       +3     
- Misses       2693     2694       +1     
  Partials      638      638              
Flag Coverage Δ
unittests 83.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link
Copy Markdown

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link
Copy Markdown

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant