Feat(storage): add bucket encryption enforcement#2190
Feat(storage): add bucket encryption enforcement#2190bshaffer merged 7 commits intoGoogleCloudPlatform:mainfrom
Conversation
Adds metadata support for the following encryption enforcement fields: - googleManagedEncryptionEnforcementConfig - customerManagedEncryptionEnforcementConfig - customerSuppliedEncryptionEnforcementConfig
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces robust capabilities for managing encryption enforcement on Google Cloud Storage buckets. It provides developers with tools to programmatically retrieve existing encryption policies, apply new enforcement rules (such as mandating Customer Managed Encryption Keys), and remove previously configured policies. This enhancement improves data security and compliance by offering granular control over how data is encrypted at rest within buckets. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds functionality and corresponding samples for managing bucket encryption enforcement configurations. The changes include new scripts for setting, getting, and removing these configurations, along with integration tests. The implementation of the core functionality is clear and correct. My review focuses on improving the new tests for better robustness and maintainability. I've suggested making test assertions more specific and refactoring duplicated code in the test suite.
Updates the encryption enforcement sample to a single consolidated file under the `storage_update_encryption_enforcement_config` region tag. The updated sample now covers both partial updates (restriction modes) and the full removal of enforcement configurations.
Updates the region tags to include the 'bucket' keyword for better consistency with other GCS samples: - storage_get_bucket_encryption_enforcement_config - storage_update_bucket_encryption_enforcement_config - storage_set_bucket_encryption_enforcement_config
nidhiii-27
left a comment
There was a problem hiding this comment.
LGTM, just update the set encryption config sample to demonstrate the right case.
- Refactor `set_bucket_encryption_enforcement_config` to apply enforcement settings during bucket creation instead of a separate update call. - Rename test variable to `$enforcementBucketName` to better align with `BucketEncryptionEnforcementConfig`. - Update PHPUnit test suite to use a dependent data-passing flow for improved reliability and cleaner logic.
@nidhiii-27 Addressed. The config is now applied at creation, and tests have been updated to reflect the new flow. |
Adds metadata support for the following encryption enforcement fields: