Skip to content

fix : Sync Make Path Editable state between path tool and menu bar #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Annonnymmousss wants to merge 1 commit into from
Closed

fix : Sync Make Path Editable state between path tool and menu bar #3496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/src/messages/menu_bar/menu_bar_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ use crate::messages::prelude::*;
pub enum MenuBarMessage {
// Messages
SendLayout,
UpdateMakePathEditableState { allowed: bool },
}
4 changes: 4 additions & 0 deletions editor/src/messages/menu_bar/menu_bar_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ impl MessageHandler<MenuBarMessage, ()> for MenuBarMessageHandler {
MenuBarMessage::SendLayout => {
self.send_layout(responses, LayoutTarget::MenuBar);
}
MenuBarMessage::UpdateMakePathEditableState { allowed } => {
self.make_path_editable_is_allowed = allowed;
self.send_layout(responses, LayoutTarget::MenuBar);
}
}
}

Expand Down
10 changes: 10 additions & 0 deletions editor/src/messages/tool/tool_messages/path_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,6 +1575,11 @@ impl Fsm for PathToolFsmState {

shape_editor.set_selected_layers(target_layers);

tool_data.make_path_editable_is_allowed = make_path_editable_is_allowed(&mut document.network_interface).is_some();
responses.add(MenuBarMessage::UpdateMakePathEditableState {
allowed: tool_data.make_path_editable_is_allowed
});

responses.add(OverlaysMessage::Draw);
self
}
Expand Down Expand Up @@ -3127,6 +3132,11 @@ impl Fsm for PathToolFsmState {

tool_data.make_path_editable_is_allowed = make_path_editable_is_allowed(&mut document.network_interface).is_some();
tool_data.update_selection_status(shape_editor, document);

responses.add(MenuBarMessage::UpdateMakePathEditableState {
allowed: tool_data.make_path_editable_is_allowed
});

self
}
(_, PathToolMessage::ManipulatorMakeHandlesColinear) => {
Expand Down