Fix disabled state of Layer > Make Path Editable menu action getting out of sync #3497
Conversation
|
|
||
| shape_editor.set_selected_layers(target_layers); | ||
|
|
||
| responses.add(MenuBarMessage::SendLayout); |
There was a problem hiding this comment.
In both of these calls, MenuBarMessage::SendLayout is expensive. Can you find a way to check if a re-send is necessary before making the call, so it's conditional instead of always?
There was a problem hiding this comment.
ya sure
we can add the condition whether the state is changed or not before calling these that would be better.
There was a problem hiding this comment.
i have added the check is it fine now?
There was a problem hiding this comment.
I think you made a mistake in the lower of the two code change areas?
There was a problem hiding this comment.
ya shit i forgot to apply the check
There was a problem hiding this comment.
also SelectionChanged does not need to store the state so removed that too
Keavon
force-pushed
the
fix-make_path_editable-sync
branch
from
4e0071b to
d4ba255
Compare
|
!build |
|
Keavon
changed the title
|
You will need to set up your code editor to auto format on save to ensure you never push code with noncompliant formatting. Please resolve that on your end and push the change so CI passes. Thanks. |
|
default formatter only or any specific style? |
|
yeah done will keep this is mind |
2 participants
fix the issue by updating the state of menu bar as the state of path tool changes
code todo - https://discord.com/channels/731730685944922173/881073965047636018/1415971652470181984
solved.mov