refactor: split TextButton.kt into multiple focused files for better organization#1293
refactor: split TextButton.kt into multiple focused files for better organization#1293aneepal55 wants to merge 1 commit into
Conversation
|
Thanks for picking this up @aneepal55 ! The code analysis check failed on some ktlint style violations — running ./codeAnalysis.sh before each commit will auto-fix those and keep CI green. |
|
Good work on the refactor @aneepal55! Please make the corrections as suggested by @Tarek-Bohdima in order to merge. |
Tarek-Bohdima
left a comment
There was a problem hiding this comment.
Hi @aneepal55 — nice work on this, the split itself is clean and test/screenshot CI is green. It's gone stale (~3 weeks) and master has moved, so it needs a rebase before it can land. Three steps:
1. Renumber the task folder. task_18 was taken by #1295/#1296, and task_22 is in-flight on #1303 — please move docs/tasks/task_18/ → docs/tasks/task_23/.
2. Carry over the #1274 fix (important). While this was open, #1274 merged a global navigation throttle and changed LanguageButton from navigate() to throttledNavigate(). Your new LanguageButton.kt still has the old call, so when you rebase:
- resolve the
TextButton.ktconflict by keeping the deletion (LanguageButton moved out), and - in
LanguageButton.kt, changenavController.navigate(LanguageRoute())→navController.throttledNavigate(LanguageRoute())and addimport org.greenstand.android.TreeTracker.utilities.throttledNavigate.
Otherwise the rebase silently drops the crash fix and the white-screen-on-rapid-tap bug comes back — the conflict shows up in TextButton.kt, but the line that matters is in your new file.
3. Run ./codeAnalysis.sh to clear the code analysis (ktlint) failure, then push.
Could you do this in the next couple of days? If you can't get back to it, no worries — say the word and we'll finish the rebase so it makes 2.3. Thanks again!
|
@Tarek-Bohdima , I will find someone else to work on this task as @aneepal55 is no longer available. |
|
👋 Hi @aneepal55, thanks for the contribution! Before this PR can be reviewed and merged, please add:
Just drag-and-drop the file(s) into the PR description and GitHub will upload them. This check re-runs automatically when you edit the description. If this change has no user-visible effect, tick the "no user-visible / UI effect" box in the description (or ask a maintainer to add the |
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./codeAnalysisto automatically apply formatting/linting)Fixes #1237 🦕