-
Notifications
You must be signed in to change notification settings - Fork 51
[WIP] Summoning followers #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ilwyd
wants to merge
41
commits into
GregHib:main
Choose a base branch
from
Ilwyd:summoning-followers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregHib
reviewed
Aug 12, 2025
engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/player/Player.kt
Outdated
Show resolved
Hide resolved
|
This is sick. |
Contributor
Author
Thanks, slowly working my way through it when I have the time 😅 |
3acfb65 to
ece4665
Compare
Contributor
Author
|
Screwed up my rebase I guess. Will fix it |
…llower if applies to both)
5ccdfaa to
847be78
Compare
Contributor
Author
|
Branch should be all fixed up now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to add summoning followers to the game. This is intended to just the be basics of having followers and then in a future PR things like familiar combat, scroll effects, etc can be added.
Known Bugs: