Repository navigation
Conversation
The lightsim2grid bridge needs klu.h and cs.h, because lightsim2grid_core exports KLU_SOLVER_AVAILABLE. lightsim2grid >= 1.3.0 installs them with the core and puts them on lightsim2grid::core's include path (lightsim2grid PR #250), but the lookup here never looked there: with lightsim2grid installed from a wheel, none of the three places it tried has them, and configure stopped on its FATAL_ERROR before compiling anything. Accept them when one of lightsim2grid::core's include directories holds klu.h, after the explicit SUITESPARSE_INCLUDE_DIR override so that one still wins. Against an older lightsim2grid the check finds nothing and the existing lookups run as before. Also drop the comment's pointer to docs/lightsim2grid_requirements.md, which does not exist. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Benjamin Donnot <benjamin.donnot@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lightsim2grid bridge needs
klu.h/cs.h(lightsim2grid_core exportsKLU_SOLVER_AVAILABLE). lightsim2grid >= 1.3.0 ships them with the core and puts them onlightsim2grid::core's include path (Grid2op/lightsim2grid#250), but the lookup insrc/_cpp/CMakeLists.txtnever looked there: with lightsim2grid installed from a wheel it stopped on itsFATAL_ERRORat configure.This adds a step "1b" (after the explicit
SUITESPARSE_INCLUDE_DIRoverride, so that one still wins): if one oflightsim2grid::core's include directories holdsklu.h, the headers are found and nothing is added. Against an older lightsim2grid it finds nothing and the existing lookups run as before. Plus the comment / error message updated, a stale pointer to a non-existent doc dropped, and a changelog line.Tested (Linux, RTX A1000, CUDA 12.4.1, cuDSS 0.8.0,
--no-build-isolation)maintest_base_case.py,test_acpf_resolve.py,test_new_api.py: 31 passed, 9 skipped (torch not installed)Until lightsim2grid 1.3.0 is released, a build with build isolation pulls 1.2.0 from PyPI and still needs one of the other three lookups.
🤖 Generated with Claude Code