Skip to content

group link cache clean up logic looks wrong #276

Open

Description

@drmacdon

https://github.com/HDFGroup/h5pyd/blob/master/h5pyd/_hl/group.py#L978

        for n in name:
            if n.find('/') == -1 and n in self._link_db:
                # remove from link cache
                del self._link_db[name]

If name is a list, it would attempt to delete the list which doesn't exist in the _link_db cache.
If name is a string, it would iterate the characters so n wouldn't be in the _link_db cache.

Activity

  1. jreadey commented on Feb 12, 2026

    @jreadey
    Member

    Yes, you are right! I've checked in a fix to master. Will put together a release once I've fixed a few other issues.

  2. assigned and unassigned on Sep 17, 2026
  3. moved this from To be triaged to Planning in HSDS - TRIAGE & TRACKon Sep 18, 2026
  4. added theissue type on Sep 18, 2026
  5. moved this from Planning to In progress in HSDS - TRIAGE & TRACKon Sep 18, 2026
  6. updated Effort Small and Priority P2 - Medium on Sep 18, 2026
  7. added this to the h5pyd 1.1.0 milestone on Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Fields

Priority

P2 - Medium

Effort

Small

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions