Depend on h5json from PyPI - #301
Merged
Merged
Conversation
h5json was pulled straight from hdf5-json's master branch, which PyPI rejects: direct URL references are not allowed in Requires-Dist, so the release workflow's upload would have failed even though twine check passes locally. It was the only such dependency h5pyd had. h5json 2.0.0 is now published, so depend on it normally. The built wheel carries 'Requires-Dist: h5json>=2.0.0' and no direct URLs at all, which is what makes h5pyd publishable. Also drop the commented-out 'h5json >= 2.0.0' left beside it, which was a placeholder for this change. Tracking master also meant every install resolved against whatever hdf5-json happened to be at that moment; a released version is reproducible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.