Send H5S_NULL shape when creating null space datasets - #303
Merged
Merged
Conversation
HsdsPlugin.createObjects() only put a "shape" key in the dataset create request for H5S_SIMPLE shapes. For H5S_NULL it left the key out, and HSDS treats a missing shape as scalar, so every null space dataset created through h5pyd (including via hsload) was stored as H5S_SCALAR. Reading it back then returned a scalar value instead of Empty. After this PR, it will send "H5S_NULL" for null shapes, which HSDS already accepts. The existing null space tests didn't catch this because they read the shape from the client-side cache. The new test reopens the file so the shape comes from the server, and checks that a scalar dataset stays scalar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HsdsPlugin.createObjects() only put a "shape" key in the dataset create request for H5S_SIMPLE shapes. For H5S_NULL it left the key out, and HSDS treats a missing shape as scalar, so every null space dataset created through h5pyd (including via hsload) was stored as H5S_SCALAR. Reading it back then returned a scalar value instead of Empty.
After this PR, it will send "H5S_NULL" for null shapes, which HSDS already accepts.
The existing null space tests didn't catch this because they read the shape from the client-side cache. The new test reopens the file so the shape comes from the server, and checks that a scalar dataset stays scalar.