Repository navigation
Refuse to start the head node without target node counts - #483
Merged
Merged
Conversation
Since 1.0.0 the head node admits nodes into a fixed number of slots, sized from target_sn_count and target_dn_count, and reports READY once every slot is filled. Both default to 0, so with them unset no node is admitted, the cluster stays WAITING and every request gets a 503 response. The shipped Compose files set them, so only custom deployments are affected. The head node now logs an error and exits at startup if either count is below 1. Treating 0 as "any number of nodes", as 0.9.x did, would let the roster grow as nodes arrive, and since partitions are hash % dn_count, nodes would disagree about where objects live.
github-project-automation
Bot
moved this from To be triaged
to Done
in HSDS - TRIAGE & TRACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.0.0 the head node admits nodes into a fixed number of slots, sized from target_sn_count and target_dn_count, and reports READY once every slot is filled. Both default to 0, so with them unset no node is admitted, the cluster stays WAITING and every request gets a 503 response. The shipped Compose files set them, so only custom deployments are affected.
The head node now logs an error and exits at startup if either count is below 1. Treating 0 as "any number of nodes", as 0.9.x did, would let the roster grow as nodes arrive, and since partitions are hash % dn_count, nodes would disagree about where objects live.