fix(memory): parse update facts JSON with raw_decode#646
Merged
Conversation
Trailing prose with braces made the greedy rfind slice invalid, so _parse_facts silently dropped valid facts. Decode the first object.
Collaborator
|
Thanks for your contribution! |
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
…de-dev fix(memory): parse update facts JSON with raw_decode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_facts is a tolerant LLM JSON parser, but _extract_json_object used a greedy rfind("}") slice. Trailing prose that itself contains braces made the slice invalid, so valid facts were silently dropped. Decode the first JSON object with raw_decode (same approach as line-edit parsing).
Repro:
{"facts":[...]} trailing {note}previously returned [].