[Feature] [Bugfix] 资源包有关优化与修复 by Calboot · Pull Request #4980 · HMCL-dev/HMCL

Calboot · 2025-12-14T02:38:29Z

资源包管理界面边框样式修复
修复资源包依赖模组下载错误的问题
资源包启用/禁用功能
资源包详细信息界面
与模组管理界面同步
更新资源包

具体改动

修复了资源包管理界面元素边框过粗的问题
Fixes [Bug] 以资源包前置方式下载模组，模组被错误下载到资源包文件夹 #4680
修复光影包下载对话框标题错误的问题
添加启用/禁用资源包功能（实验性，有警告）
添加资源包详细信息界面
移除资源包删除按钮，改为与模组界面一致的删除逻辑
Fixes [Bug] 实例管理-资源包管理页面有概率无法用esc退回到主界面 #5037
从一些类里抽象出LocalAddonFile和LocalFileManager<T extends LocalAddonFile>，使更新对于模组以外的东西（如资源包和光影包）也能适用，从而实现了资源包更新（不保留旧版本）
Fixes [Bug] 在“下载资源包”页面中，未正确选中当前编辑的版本，且下载存储位置错误。 #5207
让资源包光影包下载也有推荐项

Calboot · 2025-12-14T04:32:36Z

需要懂其他语言的人完善 i18n

在BMC4中测试时发现BMC4会判定所有资源包兼容，与原版表现不符，会导致启用/禁用功能失效，故添加警告

3gf8jv4dv

~~我在 CF 和 MR 分别下载了好几个资源包，结果都显示「游戏版本元数据缺失」。如果真的要为这个显示警告的话，可能很多人都会迷惑。~~

可能是我搞错了，我还在弄清楚这一块。

HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackFile.java

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

HMCL/src/main/resources/assets/lang/I18N_zh.properties

3gf8jv4dv · 2025-12-17T13:12:53Z

我下载了 Translations for Sodium，放在 1.21.9~1.21.11 的资源包文件夹内，启动器会显示「游戏版本元数据缺失」。1.21.8 和 1.21.1 正常。不知道是不是 bug。

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Calboot · 2025-12-17T13:31:57Z

我下载了 Translations for Sodium，放在 1.21.9~1.21.11 的资源包文件夹内，启动器会显示「游戏版本元数据缺失」。1.21.8 和 1.21.1 正常。不知道是不是 bug。

确实是，我在修

…esourcepack-enhancement

Calboot · 2025-12-18T12:09:42Z

我下载了 Translations for Sodium，放在 1.21.9~1.21.11 的资源包文件夹内，启动器会显示「游戏版本元数据缺失」。1.21.8 和 1.21.1 正常。不知道是不是 bug。

Solved

…ListPage.java

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/CheckUpdatesTask.java:42

CheckUpdatesTask is still typed against LocalModFile.ModUpdate, but LocalModFile.ModUpdate was removed (updates are now LocalAddonFile.ModUpdate). This will not compile; update the dependents list type and the candidate/update variables to use LocalAddonFile.ModUpdate consistently (and drop the unnecessary LocalModFile import).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcePackManager.java

Copilot · 2026-02-08T13:04:39Z

HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java

+    /// Turns `List.of("a", "b", "c")` into `["a", "b", "c"]`
+    @Contract(pure = true)
+    public static String serializeStringList(List<String> list) {
+        if (list == null) return "[]";
+        try {
+            return JsonUtils.UGLY_GSON.toJson(list.stream().filter(Objects::nonNull).toList(), JsonUtils.listTypeOf(String.class).getType());
+        } catch (Exception e) {
+            return "[]";
+        }
+    }
+
+    /// Turns `["a", "b", "c"]` into `List.of("a", "b", "c")`
+    @Contract(pure = true)
+    public static List<String> deserializeStringList(String list) {
+        if (list == null || list.isBlank()) return List.of();
+        try {
+            return JsonUtils.fromNonNullJson(list, JsonUtils.listTypeOf(String.class));
+        } catch (Exception e) {
+            return List.of();
+        }


serializeStringList/deserializeStringList swallow all exceptions and return an empty list/[]. Because these helpers are used to persist options.txt values (e.g., resourcePacks), a transient/format error will cause the caller to overwrite the original value with an empty list, potentially losing the user’s enabled-pack configuration. Consider narrowing the catch to JSON parse exceptions and either (1) rethrow/return a failure signal so callers can avoid saving, or (2) at least log and return the original input unmodified when parsing fails.

如果有 json 格式错误那必然会全部失效，游戏内也一样

我读了代码，mc 也是用的 gson 读取，所以我认为没问题

Copilot · 2026-02-08T13:04:40Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java

+                Predicate<@Nullable String> predicate;
+                if (queryString.startsWith("regex:")) {
+                    try {
+                        Pattern pattern = Pattern.compile(queryString.substring("regex:".length()));
+                        predicate = s -> s != null && pattern.matcher(s).find();
+                    } catch (Throwable e) {
+                        LOG.warning("Illegal regular expression", e);
+                        return;
+                    }


In search(), when the query starts with regex:, the code clears listView.getItems() before compiling the pattern. If Pattern.compile(...) throws, the method returns early and the list stays empty until the user manually closes the search bar. Compile/validate the regex before clearing, or restore the original items (or show an in-UI validation message) when the regex is invalid.

CC @Glavo
这个是历史遗留问题吗

HMCLCore/src/test/java/org/jackhuang/hmcl/resourcepack/ResourcePackManagerTest.java

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalFileManager.java

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModManager.java

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (4)

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/PackMcMeta.java:1

The sentinel value for UNSPECIFIED has changed from (0, 0) to (-1, -1). This is a breaking change that could affect existing code comparing against the old sentinel values. Consider documenting this change or providing a migration path.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/PackMcMeta.java:1
The isUnspecified() check should ensure both values are negative to match the UNSPECIFIED constant (-1, -1), not just one or the other. Use AND (&&) instead of OR (||) to properly identify the unspecified state.
HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java:1
Using triple-slash (///) for comments is unconventional in Java. Standard JavaDoc comments should use /** */ for documentation, or // for single-line comments.
HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java:1
Using triple-slash (///) for comments is unconventional in Java. Standard JavaDoc comments should use /** */ for documentation, or // for single-line comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalAddonFile.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalFileManager.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonUpdatesPage.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java

Glavo · 2026-02-11T12:48:35Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java

+
+    private void setSelectedEnabled(List<ResourcePackInfoObject> selectedItems, boolean enabled) {
+        if (!ConfigHolder.globalConfig().isResourcePackWarningShown()) {
+            Controllers.confirmWithCountdown(


哪里移除了？这不还是在用 confirmWithCountdown？

Calboot added 4 commits December 14, 2025 10:32

修复资源包管理界面边框样式问题

652491c

修复 HMCL-dev#4680

2bc3fa7

update

c5406e3

修复光影包界面下载标题错误

facdd47

Calboot changed the title ~~[Enhancement] 资源包有关优化与修复~~ [Enhancement] [Bugfix] 资源包有关优化与修复 Dec 14, 2025

Calboot added 7 commits December 16, 2025 17:49

资源包启用/禁用功能

d24b7b2

同步模组管理界面 Part1

a2b5e8b

为不兼容资源包添加警告

2ca2f3e

update

ce9377b

启用/禁用资源包时添加警告

bd96337

在BMC4中测试时发现BMC4会判定所有资源包兼容，与原版表现不符，会导致启用/禁用功能失效，故添加警告

资源包详细信息界面

bc229e3

修复esc键失效

777aea3

3gf8jv4dv reviewed Dec 17, 2025

View reviewed changes

Calboot and others added 2 commits December 17, 2025 21:28

Update i18n

e7c4f2e

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update i18n

07a9cc0

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Calboot added 2 commits December 18, 2025 20:01

完善资源包版本解析

9aca021

Merge remote-tracking branch 'origin/resourcepack-enhancement' into r…

eacf26b

…esourcepack-enhancement

Calboot added 2 commits December 18, 2025 22:50

从模组管理界面同步

8d44424

update

00b377a

Calboot marked this pull request as ready for review December 18, 2025 14:53

Calboot added 4 commits December 19, 2025 21:30

update i18n

7d2ea79

移除资源包删除按钮

8ba09cf

Merge branch 'HMCL-dev:main' into resourcepack-enhancement

ae789fb

添加cf/modrinth页面检测 & fix i18n

9f6f42b

Glavo requested a review from Copilot December 20, 2025 08:43

Copilot started reviewing on behalf of Glavo December 20, 2025 08:43 View session

Calboot added 2 commits January 29, 2026 21:30

Apply AI suggestions

0e96a9d

Merge branch 'main' into resourcepack-enhancement

05e60d6

Calboot requested a review from Glavo January 30, 2026 11:24

Calboot added 12 commits February 1, 2026 16:36

Merge

6a7f453

Delete HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Resourcepack…

72d9ca3

…ListPage.java

Fix HMCL-dev#5207

5f864a9

Merge branch 'main' into resourcepack-enhancement

871bd87

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

update

63f93d7

Merge

774c2b7

update

4f0fa24

update

1bee3f7

update

063ff8c

Merge

1ed3dbe

Merge branch 'HMCL-dev:main' into resourcepack-enhancement

e9cc88e

update

c60634e

Glavo requested a review from Copilot February 8, 2026 12:58

Copilot started reviewing on behalf of Glavo February 8, 2026 12:58 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Calboot added 2 commits February 8, 2026 21:06

update

e5a3870

Apply suggestions

b54ae5d

Glavo requested a review from Copilot February 11, 2026 12:33

Copilot started reviewing on behalf of Glavo February 11, 2026 12:33 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalAddonFile.java Show resolved Hide resolved

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalAddonFile.java Show resolved Hide resolved

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java Show resolved Hide resolved

Glavo reviewed Feb 11, 2026

View reviewed changes

Calboot added 6 commits February 19, 2026 22:58

Merge branch 'main' into resourcepack-enhancement

55f6974

rename

146c601

update

2ef2c1a

update

25677c2

update

835f416

update

abd05e2

Conversation

Calboot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Calboot commented Dec 14, 2025

Uh oh!

3gf8jv4dv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

3gf8jv4dv commented Dec 17, 2025

Uh oh!

Calboot commented Dec 17, 2025

Uh oh!

Calboot commented Dec 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Calboot Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Calboot Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glavo Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Calboot commented Dec 14, 2025 •

edited

Loading

3gf8jv4dv left a comment •

edited

Loading