-
Notifications
You must be signed in to change notification settings - Fork 7
Hanna_Dubyna-w1-Node #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Hanna_Dubyna-w1-Node #4
Conversation
|
Important clarification: I couldn't fork the /Node.js-Cohort53 repo because I had already forked its parent repo /Node.js. So, I did all the work inside my /Node.js fork. Later, I created a copy of the branch, renamed it, and opened a PR for /Node.js-Cohort53 to be sure I’ve completed the homework assignment. As a result, I now have two branches and two PRs — one for /Node.js and one for /Node.js-Cohort53. Also, some commits related to prep.exercises were accidentally included - one of them addition of nodemon, which I had installed globally for prep.exercise. |
|
Hi @HannaInIT , You seem to have done the assignment and prep exercise from Week 1, but the practice exercises are missing. Here's the full instructions: https://github.com/HackYourAssignment/Node.js-Cohort53/blob/main/week1/MAKEME.md |
|
Hello @hacdias, |
|
Hello @hacdias, here is a link to branch with practice exercises https://github.com/HannaInIT/Node.js/tree/hanna-dubyna/practice-exercises-w1-node. Please check it at your convinience. |
|
Hey @HannaInIT: They should be in the same branch, so that I can review them in this PR. |
|
Done:) |
hacdias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exercises for Week 1 look great. Congratulations!
I see you also added some Week 2 exercises. I will look at those once you have made the submission for Week 2.
|
Thank you for checking, Henrique! |
No description provided.