Repository navigation
Prepare uphold 1.25.1 - #302
Merged
Merged
Conversation
One engine change since 1.25.0. guarddog is no longer handed an npm manifest with nothing it would read: no `dependencies`, an empty `dependencies`, `devDependencies` only without `GUARDDOG_NPM_INCLUDE_DEV_DEPENDENCIES=true`, or git dependencies only. It answered such a manifest with `[]`, which the section read as "guarddog reported on no dependency at all" and reported as could-not-look, so a push of a test-only package exited 2. The section now says guarddog was not asked and passes. Under that setting `devDependencies` are sorted and counted as `dependencies` are, git sources included. A manifest that does not parse is still handed to guarddog (#301). A consumer taking the pin to v1.25.1 needs no change.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 94.10% 94.13% +0.02%
==========================================
Files 46 46
Lines 21025 21025
==========================================
+ Hits 19786 19792 +6
+ Misses 1239 1233 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One engine change since 1.25.0. guarddog is no longer handed an npm manifest
with nothing it would read: no
dependencies, an emptydependencies,devDependenciesonly withoutGUARDDOG_NPM_INCLUDE_DEV_DEPENDENCIES=true,or git dependencies only. It answered such a manifest with
[], which thesection read as "guarddog reported on no dependency at all" and reported as
could-not-look, so a push of a test-only package exited 2. The section now
says guarddog was not asked and passes. Under that setting
devDependenciesare sorted and counted as
dependenciesare, git sources included. Amanifest that does not parse is still handed to guarddog (#301).
A consumer taking the pin to v1.25.1 needs no change.