Skip to content

Update Simplified Chinese translations - #1426

Open
gaenyong wants to merge 1 commit into
HearthSim:masterfrom
gaenyong:master
Open

Update Simplified Chinese translations#1426
gaenyong wants to merge 1 commit into
HearthSim:masterfrom
gaenyong:master

Conversation

@gaenyong

Copy link
Copy Markdown

Don't know if it's correct. Seems like some changes are not related to translations. I tried my best. This was my first time using Xcode. If there is still something I can do, let me know.
And I found this, I think it's the experience icon settings that I mentioned.lol
image

@fmoraes74

Copy link
Copy Markdown
Contributor

@gaenyong Do you have a CLA in place with HearthSim? That's necessary before any contributions are accepted. @beheh can help with that

@gaenyong

Copy link
Copy Markdown
Author

Oh, I don't have one. I actually just know this CLA thing XD. what should I do?

@fmoraes74

Copy link
Copy Markdown
Contributor

Oh, I don't have one. I actually just know this CLA thing XD. what should I do?

@beheh will help you with that process.

@gaenyong

Copy link
Copy Markdown
Author

Ok, I'll wait for him to contact me. Or should I contact him?

@beheh

beheh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Hi @gaenyong, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know.

Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible.

@gaenyong

Copy link
Copy Markdown
Author

@beheh Hi, I've signed it.

@fmoraes74

Copy link
Copy Markdown
Contributor

@beheh are we ok to proceed?

@gaenyong Can you update the PR with the resolved conflicts?

@gaenyong

gaenyong commented Jul 25, 2026

Copy link
Copy Markdown
Author

@fmoraes74 I'd like to but lots of conflicts look like this
image
Chinese to French? I don't know how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants