First version of the style: terrain, water, roads and per-course hole colors (#7)#49
Draft
HuggeK wants to merge 6 commits into
Draft
First version of the style: terrain, water, roads and per-course hole colors (#7)#49HuggeK wants to merge 6 commits into
HuggeK wants to merge 6 commits into
Conversation
… compute hue value for a particular course name, (Use route=golf people!) Added lakes, rivers, waste areas, golf hole text info and coloring, roads, paths, to style.
Owner
Author
|
Set a release for this too. |
- Add top-level glyphs pointing at GitHub Pages hosted fonts (docs/fonts/, see companion publishing PR); keeps Open Sans Regular so the 5 symbol layers can finally draw text. - Streams and Rivers: read source-layer golf_lines (process.lua writes waterway=* there, not golf_areas). - Area:highway: filter on area_highway, the attribute key actually written to the tiles. - Lakes: also render water=river polygons; layer renamed to 'Lakes and rivers'. - Hole labels: read hole_number (the renamed ref) so 'Hole N.' renders. - Document all of the above in styles/schema_and_style.md. Co-authored-by: HuggeK <48095810+HuggeK@users.noreply.github.com>
Unpinned unpkg URLs float to the latest major and can break the page silently; 5.24.0 matches the version the style was verified against. The relative style URL resolves to the same path on golftiles.org while letting local development serve the branch's own style instead of the deployed copy. Co-authored-by: HuggeK <48095810+HuggeK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues #7. Grows the style from 17 to 33 layers and adds 3D terrain:
process.luanow precomputes acourse_name_colorattribute (FNV-1a hash of the course name → hue →#rrggbb) intogolf_lines; theHole lineslayer consumes it with a#ccccccfallback.terrainSource(Mapterhorn raster-DEM) plus top-levelterrain(exaggeration 1.5) andsky; the demo page now starts pitched at 70° with navigation and terrain controls.other_areassource-layer),area:highway, parking lots, cartpaths, golf paths, highways, clubhouses, restaurants, buildings.Out of bounds linesfilter — it previously matchedgolf=holeinstead ofgolf=out_of_bounds.styles/schema_and_style.md; broadens waterway handling inprocess.luato anywaterway=*tag.Second round of fixes (2026-07-05)
Resolves all of the previously listed follow-ups plus three more schema/style mismatches found while auditing the style against
process.lua:glyphspointing at self-hostedOpen Sans Regularglyph ranges on GitHub Pages. The font files themselves ship in companion PR Publish the style, samples and fonts to GitHub Pages on release #52 (merge this PR first, then Publish the style, samples and fonts to GitHub Pages on release #52).Streams and Riversfixed — now readssource-layer: golf_lines, whereprocess.luaactually writeswaterway=*features.Area:highwayfixed — now filters onarea_highway, the attribute key actually written to the tiles (colon → underscore).Lakeslayer (renamedLakes and rivers) now matcheswater=lakeandwater=river;process.luaemits both fornatural=water.ref, but the schema renames it tohole_number; "Hole N." now works.index.htmlhardening —maplibre-glpinned to5.24.0(was floating latest) and the style is loaded relatively, so local testing serves the branch's own style instead of the deployed golftiles.org copy.styles/schema_and_style.md.Verification
style.loadfired, zeroerrorevents — re-run after the second round of fixes).glyphstemplate well-formed; every layer'ssource-layerexists incustom-tilemaker/config.json; the corrected filters (golf_lineswaterways,area_highway,lake+river,hole_number, norefreads);index.htmlfully pinned and loading the style relatively.Deployment notes for golftiles.org (read before uploading)
styles/golfTilesStyle.jsonfrom this branch after merge to publish the improvements.["hsl", ["get", "course_name_hash_hue"], 70, 50]expression is invalid in MapLibre (hsl is not an expression), which fails validation of the whole style and blanks the map. The branch tip replaced it with the precomputedcourse_name_color.process.luachange — its metadata has nocourse_name_colorfield — so hole lines will render the#ccccccfallback until the tiles are regenerated with the newprocess.lua.glyphsURL points at the Pages-hosted fonts).Known follow-ups (not blocking this PR)
process.luasocourse_name_color(and the broadenedwaterway=*handling) is actually present in the tiles.🤖 Generated with Claude Code