fix: await drain when waitUntil is unavailable#100
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves evlog’s log-draining reliability in edge/serverless runtimes by ensuring drain work is not dropped when waitUntil isn’t available.
Changes:
- Nitro v2 plugin:
awaitdrain as a fallback when nowaitUntilexists. - Nitro v3 plugin: make drain hook async, schedule via
waitUntilwhen available, otherwiseawaitdrain; update call site toawait.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/evlog/src/nitro/plugin.ts | Adds a no-waitUntil fallback that awaits drain to reduce lost logs. |
| packages/evlog/src/nitro-v3/plugin.ts | Refactors drain hook to be awaitable and adds the same no-waitUntil fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of log draining in serverless and edge environments by ensuring that drain operations are properly awaited when
waitUntilis not available. The changes update both the Nitro v3 and v2 plugins to prevent lost logs and clarify the handling of background log draining.