Skip to content

fix: harden clob download error handling - #235

Merged
krowvin merged 1 commit into
mainfrom
fix-195-blob-download-path-safety
Jul 11, 2026
Merged

fix: harden clob download error handling#235
krowvin merged 1 commit into
mainfrom
fix-195-blob-download-path-safety

Conversation

@krowvin

@krowvin krowvin commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep default blob/clob downloads on safe relative paths when IDs start with / or \
  • fix CLOB download/list scoped-read hint handling so HTTP failures report the intended access hint
  • avoid showing CDA credential-scope hints for local filesystem write/path failures
  • log the actual blob download path after extension detection

Why

Blob and CLOB IDs can look like paths, but default downloads should never write to filesystem root. Local destination failures should point users toward --dest, while real CDA HTTP failures can still show credential-scope guidance.

Validation

  • poetry run pytest tests/commands/test_download_dest_safety.py tests/commands/test_blob_upload.py tests/commands/test_clob.py -q
  • poetry run pytest -q
  • poetry check (warnings only for existing Poetry metadata deprecations)

@krowvin
krowvin marked this pull request as ready for review July 11, 2026 21:51
@krowvin
krowvin requested a review from Enovotny as a code owner July 11, 2026 21:51
@krowvin
krowvin merged commit 621f913 into main Jul 11, 2026
9 checks passed
@krowvin
krowvin deleted the fix-195-blob-download-path-safety branch July 11, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant