Add reproducible dev container - #243
Open
krowvin wants to merge 2 commits into
Open
Conversation
krowvin
commented
Jul 30, 2026
Comment on lines
+6
to
+7
| - Use JDK 21 at `C:\Program Files\Java\jdk-21` unless a task specifically needs | ||
| another Java version. |
Collaborator
Author
There was a problem hiding this comment.
I'm assuming we're using into Java 21 atm for enterprise targets (Batch/etc)
But probably should have a line in her for linux/nix OS
There was a problem hiding this comment.
Basically anything new, and not intended to run on the T7s should be Java 21 or higher.
krowvin
marked this pull request as ready for review
July 30, 2026 21:32
MikeNeilson
requested changes
Jul 30, 2026
| jobs: | ||
| test: | ||
| name: Test CLI on ${{ matrix.python-version }} | ||
| test-python-39: |
There was a problem hiding this comment.
don't remove the matrix. It will eventually get used.
| - name: Run full test suite | ||
| run: poetry run pytest -q | ||
|
|
||
| test-python-312: |
There was a problem hiding this comment.
Okay, really don't remove the matrix.
Create a new job (in this file) specific to testing the dev container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
poetry run pytest -qin the dev container (225 passed)poetry run pre-commit run --all-filesin the dev container